Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MJML Official keepComments not available #60

Open
colungafc opened this issue Jan 24, 2025 · 1 comment
Open

MJML Official keepComments not available #60

colungafc opened this issue Jan 24, 2025 · 1 comment

Comments

@colungafc
Copy link

VISUAL CODE Extension: MJML Official
Identifier: mjmlio.vscode-mjml
Version: 2.0.0
Last Updated: 2024-11-15, 09:01:29

When executing MJML: version command
MJML version: 5.0.0-alpha.6

This version doesn't support keepComments setting.
{ "[html]": { "editor.defaultFormatter": "esbenp.prettier-vscode" }, "mjml.nodemailer": { }, "mjml.screenshotWidths": [ 640, 750 ], "mjml.beautify": { "indent_size": 2, "wrap_attributes_indent_size": 2 }, "mjml.beautifyHtmlOutput": true, "mjml.minifyHtmlOutput": false, "mjml.keepComments": true, }

"mjml.keepComments": true is marked as Unknown Configuration Setting

It would be very useful to have this setting available and have the option to keep the custom comments when MJML: Export HTML as was available in previous versions. I'm currently adding the comments manually and it's a hard job :-)

Thanks in advance!!

@iRyusa
Copy link
Member

iRyusa commented Jan 28, 2025

I'll push a version with it available it should be simple enough as it just forward the options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants