Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about rails port of twbs #70

Open
twetzel opened this issue Jul 27, 2014 · 4 comments
Open

How about rails port of twbs #70

twetzel opened this issue Jul 27, 2014 · 4 comments

Comments

@twetzel
Copy link

twetzel commented Jul 27, 2014

because from a rails perspective the new structure of twbs/bootstrap-sass really sucks,
would be great to keep this project

everything should/can be copied from twbs/bootstrap-sass but keep the old vendor/assets/.. structure so the app or other gems can override original sass .. what is one of the best features of the asset-pipeline .. but completely destroyed by the new structure of twbs/bootstrap-sass since 3.2.0

thanks

@mjonuschat
Copy link
Owner

I'm sorry, but I might be missing the point. Looking at the bootstrap-sass gem they are just appending some include paths to the asset pipeline. This alone shouldn't cause any problems as far as I can see.

Dropping a file with the same name in a directory as an override didn't work with this gem at any point in time that I know off. If you wanted to override bootstrap in either one of the gems you needed to cherry-pick the partials you wanted and add your additional files at the appropriate places. That's what bootstrap-custom.scss is for with the official gem and it's the same way this gem has been employing for a long time.

@twetzel
Copy link
Author

twetzel commented Jul 27, 2014

I did that sometimes (but didn't check in rails 4) .. problem is also you can't use from another gem because the tweak of gem pathes only affects the app not other gems .. had quiet a lot of problems with that structure change. maybe great for node.js and co, but its not for rails (in opinion a gem for asset pipeline should not tweak the asset pipeline)

@twetzel
Copy link
Author

twetzel commented Jul 27, 2014

checked in rails 4 its still possible to override gem-css (at least when that is in vendor/assets/...) when you place an file with the same name in your application app/assets/.. folder (need the same relative path)

@mjonuschat
Copy link
Owner

Hmm, I can't get that to reliably work here - at the latest it fails when precompiling the assets. Did you try that in a production environment or just with a local dev setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants