Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using with router5 #218

Open
jonaskello opened this issue Dec 4, 2017 · 3 comments
Open

Using with router5 #218

jonaskello opened this issue Dec 4, 2017 · 3 comments

Comments

@jonaskello
Copy link

Is redux-auth-wrapper compatible with router5?

@mjrussell
Copy link
Owner

It should definitely be possible, that was one the primary reasons for the refactoring in v2. I think you'd write something similar to this redirect. getRouterRedirect looks like it should return router.navigate.

The locationHelperBuilder is maybe a little more tricky, it needs to be an object that returns two functions: getRedirectQueryParam should pull /dashboad out of a url like http://my-app.example.com/login?redirect=%2fdashboard. createRedirectLoc is used to build the object to be passed to the router.navigate function.

@Ammonix
Copy link

Ammonix commented Feb 12, 2018

@mjrussell are you gonna include router5?

@mjrussell
Copy link
Owner

I dont plan on writing support myself, no. But if someone wants to work on it and submit a PR I'd be happy to review it and try to get it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants