Access control change - /changes/ endpoint now available to all users…

… with read access to that dataset
mkdf · May 11, 2022 · 4f6993f · 4f6993f
1 parent 108b6b7
commit 4f6993f
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 6 deletions.
diff --git a/module/apif-core/src/Controller/ActivityController.php b/module/apif-core/src/Controller/ActivityController.php
@@ -112,9 +112,10 @@ public function get($id) {
         $permissions = $this->getPermissionsOnDataset($roles, $id);
 
         // ######
-        // Access is granted to activity log if user/key has both READ and WRITE permission on this dataset
+        // Access is granted to activity log if user/key has READ permission on this dataset
         // ######
-        if ($permissions['read'] AND $permissions['write']) {
+        //if ($permissions['read'] AND $permissions['write']) {
+        if ($permissions['read']) {
             $activityLogId = $this->_config['activityLog']['dataset'];
             // ONLY RETRIEVE WRITE ACTIONS, NOT READS.
             $query = [

diff --git a/module/apif-core/view/apif/core/index/swagger-config-main.json b/module/apif-core/view/apif/core/index/swagger-config-main.json
@@ -11,7 +11,7 @@
       "name": "Apache 2.0",
       "url": "http://www.apache.org/licenses/LICENSE-2.0.html"
     },
-    "version": "0.9.3"
+    "version": "0.9.4"
   },
   "tags": [
     {

diff --git a/module/apif-core/view/apif/core/index/swagger-config-main.phtml b/module/apif-core/view/apif/core/index/swagger-config-main.phtml
@@ -11,7 +11,7 @@
 "name": "Apache 2.0",
 "url": "http://www.apache.org/licenses/LICENSE-2.0.html"
 },
-"version": "0.9.3"
+"version": "0.9.4"
 },
 "tags": [
 {

diff --git a/module/apif-core/view/apif/core/index/swagger-config-management.json b/module/apif-core/view/apif/core/index/swagger-config-management.json
@@ -11,7 +11,7 @@
       "name": "Apache 2.0",
       "url": "http://www.apache.org/licenses/LICENSE-2.0.html"
     },
-    "version": "0.9.3"
+    "version": "0.9.4"
   },
   "tags": [
     {

diff --git a/module/apif-core/view/apif/core/index/swagger-config-management.phtml b/module/apif-core/view/apif/core/index/swagger-config-management.phtml
@@ -11,7 +11,7 @@
 "name": "Apache 2.0",
 "url": "http://www.apache.org/licenses/LICENSE-2.0.html"
 },
-"version": "0.9.3"
+"version": "0.9.4"
 },
 "tags": [
 {