Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

GNotifier not working in new Firefox 57 #197

Closed
ivnish opened this issue Nov 17, 2017 · 10 comments
Closed

GNotifier not working in new Firefox 57 #197

ivnish opened this issue Nov 17, 2017 · 10 comments

Comments

@ivnish
Copy link

ivnish commented Nov 17, 2017

GNotifier not working in new Firefox 57. Firefox disable it.

@mkiol
Copy link
Owner

mkiol commented Nov 17, 2017

GNotifier is not a WebExtension, so it was disabled in FF 57. Unfortunately due to few constrains - see #162 - it is not possible to "fix" it to be compatible with the newest FF release.

I've decided to continue development only focusing on Thunderbird.

@ivnish
Copy link
Author

ivnish commented Nov 17, 2017

It's a pity! :(

@tooomm
Copy link
Contributor

tooomm commented Nov 18, 2017

Just curious @mkiol.
What kind of dll files are needed to make this work on windows? What do they provide?

@mkiol
Copy link
Owner

mkiol commented Nov 19, 2017

@tooomm

DLL is here and the sources are here.

Unlike Linux, on Windows GNotifier interacts with OS notification API not directly (using javascript code) but via "adaptor" implemented in C++ and provided as a DLL. GNotifier calls relatively simple js function: notify (iconURL, title, text, notifier, closeHandler, clickHandler) and DLL transforms it to something understandable by Windows API.

This crafty implementation was entirely done by @kabili207.

@tooomm
Copy link
Contributor

tooomm commented Nov 19, 2017

@mkiol
Copy link
Owner

mkiol commented Nov 19, 2017

@tooomm Unfortunately it is not so simple. Yes, there is WebExtension API for triggering notifications but this API doesn't produce "native" integration on Windows. When you call notifications.create() FF will show ugly HTML thing instead nice action center ToastNotification.

To sum up, there are following blockers for re-implementation GNotifier as a WebExtension:

  1. no DLLs and js-ctypes API -> add-on is not able to interact with native binaries in the OS*
  2. no API that allows add-on to change the default notification engine in the browser
  3. Thunderbird, SeaMonkey and PaleMoon doesn't support WebExtensions

*) Actually there is a possibility to use Native messaging API. It is ugly solution because it requires user to install EXE file in the system. This EXE file can not be distributed with the add-on via AMO. I really dislike this approach.

@tooomm
Copy link
Contributor

tooomm commented Nov 19, 2017

Thanks for investigating further.

So we are basically dependent on mozilla to support native notification systems at one point...
@kabili207 posted the tracking issue at mozilla for windows toast notifications here: #162 (comment)

No idea about other operating systems. :/

@ViBE-HU
Copy link

ViBE-HU commented Nov 25, 2017

feels bad. this is one of my daily driver extensions.

@Forage
Copy link

Forage commented Nov 30, 2017

Who cares about Windows support? We only need it to work in Firefox for Linux! ;)

@RaEyE
Copy link

RaEyE commented Dec 15, 2017

@mkiol
Thank you for your elaborate answer. Thats really nice to know.
urrently I'm using Thunderbird Beta (58b2), would you say, there is a possibility to run GNotifier with that release? I'm asking since you also published a release for Beta 56.

@ivnish ivnish closed this as completed Jan 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants