Add retry limit

[rd-daniel-alshut]

In our team it would be preferred to limit the retries to a certain number.

Describe the solution you'd like

We would need two new variables in the Actor class. The variable maxRetries should be overridable.
Integer retryNumber = 0
Integer maxRetries = 0

Currently in the Actor.class the check looks like this:
if (question.acceptable(lastAnswer)) { reporters.forEach(reporter -> reporter.success(this, question, answer)); return answer; }
It would need to be replaced by a wrapper function:



if (question.acceptableWrapper(lastAnswer)) { reporters.forEach(reporter -> reporter.success(this, question, answer)); return answer; }

default boolean acceptableWrapper(A answer){ if(maxTries!=0 && retryNumber>maxRetries) return answer tryNumber++ acceptable(answer) }

We currently use our own code to do the same. This would be a cleaner approach and it adds a valuable feature to the framework.

[mkutz]

Thanks for the suggestion.

Currently there's already a way to customize the number of retries by setting a timeout in your RetryableTask or RetryableQuestion. It is used here in the Actor's check(RetryableQuestion) method to calculate at what time the timeout is reached.

The default timeout is 2 seconds (see here in Retryable).

It is now not clear to me what you want to achieve.

• Is it the default of 2 seconds that you'd like to change to something else (e.g. 20 seconds), or
• do want to set the number of retries instead of the timeout/interval?

[rd-daniel-alshut]

The idea is to be able to set a maximum amount retries.

The proposed solution would give the option to choose whether to use a time based retry or an amount based retry behavior.