Fixes signature missmatch for component definitions #201 #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesnx
changed the title
davesnx
force-pushed
the
main
branch
2 times, most recently
from
3e10661 to
d73a247
Compare
… into issue-201-signature-mismatch * 'main' of github.com:ml-in-barcelona/server-reason-react: (21 commits) Create a basic usage page remove option from SearchField Documentation names linked properly Migrate to a app component filter notes by title install missing deps manually in the dockerfile update name in cfrs align readme and docs fix table push docker with 2.3 and _opam ignore polish readme with 0.1 vibes polish readme with 0.1 vibes rename melange-fetch to fetch update ci opam to 3.2.5 fix docs command use odoc-driver for 3.0 docs remove shit push docs remove mint and fix docs push change by git ...
…lona/server-reason-react into issue-201-signature-mismatch * 'issue-201-signature-mismatch' of github.com:ml-in-barcelona/server-reason-react: Create a basic usage page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201
Here we need to be cautious since shared code won't work with signatures (due #112). This PR adds the signature changes to work nice with native code only (we add an optional "key" argument and the last unit argument)