Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyperparameter naming in readme, add learning resources #9

Merged
merged 4 commits into from
Nov 8, 2019

Conversation

rafajak
Copy link
Contributor

@rafajak rafajak commented Nov 18, 2018

Hello there,

I made some changes in the hyperparameters section to reflect the argument names the model accepts, namely:

  • layers -> num_layers
  • dropout -> output_keep_prob

I also changed the suggested value of the latter from 0.25 to 0.75, as I'm assuming the author suggests dropout rate of 0.25, which corresponds to output_keep_prob of 0.75 in TensorFlow's DropoutWrapper.

Additionally, I added the learning resources Daniel lists in issue #7.

Thanks so much for your work on ml5 and tutorials, it's an absolute joy to play with. :)

Cheers,
Raf

@shiffman
Copy link
Member

shiffman commented Nov 8, 2019

Thank you for this, sorry for the long delay is taking a look!

@shiffman shiffman merged commit 44f4cb0 into ml5js:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants