Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNN/R-GAT Inference Submission disallows sorting of the nodes. Need a mechanism to prevent and detect sorting. #1950

Open
ukurkure opened this issue Nov 22, 2024 · 4 comments

Comments

@ukurkure
Copy link

GNN/R-GAT Inference task force agreed that the sorting of the nodes is disallowed. Sorting of the nodes reduces number of unique nodes and artificially increases the throughput up to 6x. We need a mechanism to prevent and detect sorting.

@arjunsuresh
Copy link
Contributor

@ukurkure Adding TEST04 compliance can solve this. But it is not straightforward to do this and will need time. Probably this can be targeted for 5.1. The idea of the test is as follows:

A run is done with limited number of unique inputs say 1000 and repeated 10 times.
A run is done with 10000 unique inputs
Run times are compared between the two and the difference should be within 10%.

@ukurkure
Copy link
Author

ukurkure commented Nov 26, 2024

The section 8.2. Model Equivalence needs to be updated https://github.com/mlcommons/inference_policies/blob/master/inference_rules.adoc#82-model-equivalence.
The proposed addition to the disallowed techniques:

The following techniques are disallowed:

  • Techniques that only improve performance when there are identical samples in a query. For example, sorting samples in SSD.
  • The Techniques that reduce the number of unique samples in a query. For example, sorting samples in Graph Neural Networks' RGAT.

@arjunsuresh
Copy link
Contributor

@ukurkure The below line already covers the case for R-GAT too right?

Techniques that only improve performance when there are identical samples in a query. For example, sorting samples in SSD.

@ukurkure
Copy link
Author

ukurkure commented Nov 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants