-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GNN/R-GAT Inference Submission disallows sorting of the nodes. Need a mechanism to prevent and detect sorting. #1950
Comments
@ukurkure Adding TEST04 compliance can solve this. But it is not straightforward to do this and will need time. Probably this can be targeted for 5.1. The idea of the test is as follows: A run is done with limited number of unique inputs say 1000 and repeated 10 times. |
The section 8.2. Model Equivalence needs to be updated https://github.com/mlcommons/inference_policies/blob/master/inference_rules.adoc#82-model-equivalence. The following techniques are disallowed:
|
@ukurkure The below line already covers the case for R-GAT too right? Techniques that only improve performance when there are identical samples in a query. For example, sorting samples in SSD. |
If the working group agrees that "Techniques that only improve performance
when there are identical samples in a query. For example, sorting samples
in SSD." covers RGAT, we do not have to add the RGAT case explicitly. We
could make it explicit by adding the following:
Techniques that only improve performance when there are identical samples
in a query. For example, sorting samples in SSD and RGAT.
…On Tue, Nov 26, 2024 at 6:09 PM Arjun Suresh ***@***.***> wrote:
@ukurkure <https://github.com/ukurkure> The below line already covers the
case for R-GAT too right?
Techniques that only improve performance when there are identical samples
in a query. For example, sorting samples in SSD.
—
Reply to this email directly, view it on GitHub
<#1950 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE7XMAXQPL3GUTYZUNGF7XT2CUSVVAVCNFSM6AAAAABSKHQRN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBSGUYDMMJXHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
GNN/R-GAT Inference task force agreed that the sorting of the nodes is disallowed. Sorting of the nodes reduces number of unique nodes and artificially increases the throughput up to 6x. We need a mechanism to prevent and detect sorting.
The text was updated successfully, but these errors were encountered: