New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dummy cred download into test #121

Open

achalddave opened this issue Nov 30, 2023 · 0 comments

Assignees

Collaborator

achalddave commented Nov 30, 2023

Tests currently fail locally because we download credentials in the workflow rather than in the tests. We should move this into the tests:

https://github.com/mlfoundations/open_lm/blob/b27ce1e26db571f3a6558e126a0d1cc98b58908d/.github/workflows/ci.yml#L46C1-L46C173

achalddave assigned Vaishaal

GeorgiosSmyrnis mentioned this issue

Reincorporate manifest creation. #122

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment