make tokenize-shuffle more robust to long pages #271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Issue:
Some sources (e.g. code repos, books) are prone to having very long pages leading to long lists of tokens. However, the way we currently yield sequences is to simply add all tokens from a page to the buffer and to then repeatedly slice the buffer. When buffer grows too large this can be very slow (and many slices need to take place).
Solution:
Control the max buffer size by yielding tokens from a page's token set to the buffer in a more controlled manner.