Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic context equality check #271

Open
raviqqe opened this issue Jul 26, 2023 · 0 comments · May be fixed by #360
Open

Dynamic context equality check #271

raviqqe opened this issue Jul 26, 2023 · 0 comments · May be fixed by #360
Labels
bug Something isn't working

Comments

@raviqqe
Copy link
Member

raviqqe commented Jul 26, 2023 •
edited
Loading

  • In every MLIR object constructor, we should check context equality among arguments for complete safety.
@raviqqe raviqqe added the bug Something isn't working label Jul 26, 2023
@raviqqe raviqqe mentioned this issue Jul 26, 2023
Open
45 tasks
@raviqqe raviqqe mentioned this issue Oct 14, 2023
Merged
raviqqe added a commit that referenced this issue Oct 17, 2023
@raviqqe
Initialize string cache in context (#349)
c15cecf 
This PR removes the global static string cache that stores `CString` in
MLIR (C++) for each corresponding `&str` in Rust. Instead, we have a
cache in each context. And, that forces users to pass around the new
`Context` type accordingly.

Close #54.

This change is also the base of #271, #23, and #348.
@raviqqe raviqqe linked a pull request Oct 19, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dynamic check for operations mlir-rs/melior
1 participant
@raviqqe