-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement Whitaker smoother and all the utilities to be used outside #292
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
+ Coverage 96.38% 96.51% +0.12%
==========================================
Files 184 190 +6
Lines 5152 5601 +449
Branches 1147 1214 +67
==========================================
+ Hits 4966 5406 +440
- Misses 186 195 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests
reading again the code, the operation with lambda = 1 of
It is a populated matrix of 10x10 by the indexes returned by
|
746aa2e
to
7203356
Compare
Co-authored-by: Michaël Zasso <[email protected]>
This implement an expose:
matrixCholeskySolver
accepts optionally the permutation encoded array frommatrixCuthillMckee
to reduce the bandwidth of the matrix. Both of them uses matrix in the triplet form:the internal
addWeights
receives a matrix in the triplet form and a NumberArray of the same dimension (diagonal length === array length) and add the weights.