Prevent user pref races (bluesky-social#1576)

prevent user pref races
mloar · Sep 25, 2023 · 51002e3 · 51002e3
1 parent 1a8dd27
commit 51002e3
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/packages/pds/src/services/account/index.ts b/packages/pds/src/services/account/index.ts
@@ -590,6 +590,15 @@ export class AccountService {
         `Some preferences are not in the ${namespace} namespace`,
       )
     }
+    // short-held row lock to prevent races
+    if (this.db.dialect === 'pg') {
+      await this.db.db
+        .selectFrom('user_account')
+        .selectAll()
+        .forUpdate()
+        .where('did', '=', did)
+        .executeTakeFirst()
+    }
     // get all current prefs for user and prep new pref rows
     const allPrefs = await this.db.db
       .selectFrom('user_pref')