Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation results for coco val #1

Closed
ywyue opened this issue Jun 29, 2022 · 7 comments
Closed

Evaluation results for coco val #1

ywyue opened this issue Jun 29, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@ywyue
Copy link

ywyue commented Jun 29, 2022

Hi Thanks for your great work! I loaded your pretrained model on COCO, and ran the inference. The results are as follows:

[06/29 21:55:25 d2.engine.defaults]: Evaluation results for coco_2017_val in csv format:
[06/29 21:55:25 d2.evaluation.testing]: copypaste: Task: bbox
[06/29 21:55:25 d2.evaluation.testing]: copypaste: AP,AP50,AP75,APs,APm,APl
[06/29 21:55:25 d2.evaluation.testing]: copypaste: 38.4919,59.4363,41.7748,22.3543,41.2834,50.4875
[06/29 21:55:25 d2.evaluation.testing]: copypaste: Task: segm
[06/29 21:55:25 d2.evaluation.testing]: copypaste: AP,AP50,AP75,APs,APm,APl
[06/29 21:55:25 d2.evaluation.testing]: copypaste: 7.8351,29.3128,1.0689,4.7795,8.2153,10.8173

You can see the AP results of segm is much lower than the number in your paper. I also visualize the results using tools/visualize_json_results.py . The visualized results are also not good. I have followed your default hyperparameters except that I set num-gpus as 1 and BATCH_SIZE = 8. Could you please give some hints on what may be wrong? Thanks in advance!

@ywyue ywyue added the enhancement New feature or request label Jun 29, 2022
@jlazarow
Copy link
Collaborator

Can you try this with BATCH_SIZE = 1? I realize it will take longer, but BATCH_SIZE = 8 hasn't been tested. Assuming that works, I can try and see what the problem with 8 is (generally, Detectron2 discourages using a batch size > 1 during inference and I probably assumed this somewhere in the code).

@ywyue
Copy link
Author

ywyue commented Jun 30, 2022

Hi I find the BATCH_SIZE parameter has no effect on the inference. Detectron2 always sets batch size as 1 during inference.

BTW, could you please provide the instruction to build your diff_ras module. I am not sure whether I build this module in a correct way. I just execute:
cd projects/BoundaryFormer/boundary_former/layers/diff_ras
python setup.py build_ext

@jlazarow
Copy link
Collaborator

By executing pip install -e . (or python setup.py build develop), the module should be build (and placed at the root of the repo).

With respect to the eval results, it looks like my PyTorch had issues saving it (perhaps too old of a version) and the boundary head weights were not loaded. Please re-download the COCO model, and I think it should be fine.

@ywyue
Copy link
Author

ywyue commented Jul 13, 2022

Thanks for the updated model! Yes, now it is fine. Sorry I have another question: to check whether I compiled the diff_ras module correctly, I ran run-rasterizer-tests.py and the logs look like:

image

The GT Rasterization agreement is around 0.6, Rasterized agreement (tau) and Gradient agreement (tau) are around 1.
Does this mean that the rasterizer can work properly?

@jlazarow
Copy link
Collaborator

jlazarow commented Jul 13, 2022 via email

@ywyue
Copy link
Author

ywyue commented Jul 14, 2022

Alright, thanks!

@ywyue ywyue closed this as completed Jul 14, 2022
@lixhere
Copy link

lixhere commented Oct 31, 2023

Thanks for the updated model! Yes, now it is fine. Sorry I have another question: to check whether I compiled the diff_ras module correctly, I ran run-rasterizer-tests.py and the logs look like:

image

The GT Rasterization agreement is around 0.6, Rasterized agreement (tau) and Gradient agreement (tau) are around 1. Does this mean that the rasterizer can work properly?

May I ask what these three results represent?thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants