Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expressions in learner params #767

Closed
kerschke opened this issue Mar 2, 2016 · 2 comments
Closed

expressions in learner params #767

kerschke opened this issue Mar 2, 2016 · 2 comments

Comments

@kerschke
Copy link
Contributor

kerschke commented Mar 2, 2016

As mentioned in PR #82 from ParamHelpers I started to use expressions within the mlr learners. The first steps have already been made, as you can see here.
In general, it is now possible to define expressions within the parameters of a learner. However, due to the high complexity, this now raises new issues on other ends of mlr. Here are some problems that came up:

  • weightedClassWrapper did not update the learner to the task; why does this not work? I mean, trainLearner.WeightedClassesWrapper internally calls train, which actually adapts the learner
  • in test_base_Learner.R the following call fails expect_error(makeLearner("classif.__mlrmocklearners__5"), "used 'expression'"), because PH now wants to have "a" in its dictionary (because parameter "b" requires expression(a == "x")).. do you have an idea, how to avoid this?

There are probably a lot more bugs coming up afterwards, but I thought it's best to start at some point and tackle them step-by-step..

@mb706
Copy link
Contributor

mb706 commented Mar 3, 2016

Do you plan this to work with wrappers that change properties of a task (e.g. a feature selection wrapper removing features), or will you drop the expressions when building a wrapper? I guess it wouldn't be such a problem if you have default=expression(sqrt(p)) (since the default doesn't influence actual behaviour), but len=expression(p) could be a problem.

@pat-s
Copy link
Member

pat-s commented Jun 17, 2019

Apparently solved in #1126.

@pat-s pat-s closed this as completed Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants