From 3cd1420489e881993b6790c625d52dc39f48836f Mon Sep 17 00:00:00 2001 From: kenomersmannPC Date: Sun, 22 Sep 2024 13:28:38 +0200 Subject: [PATCH 1/2] fixes #162, calculating hash --- R/Filter.R | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/R/Filter.R b/R/Filter.R index 886ad259..01a0aefa 100644 --- a/R/Filter.R +++ b/R/Filter.R @@ -229,6 +229,10 @@ Filter = R6Class("Filter", assert_ro_binding(rhs) calculate_hash(class(self), self$id, mget(private$.extra_hash, envir = self)) } + ), + + private = list( + .extra_hash = character() ) ) From 19c5b2d7f4359fe92e70e4a90935f1696de618b8 Mon Sep 17 00:00:00 2001 From: kenomersmannPC Date: Tue, 24 Sep 2024 11:43:54 +0200 Subject: [PATCH 2/2] updated NEWS.md --- NEWS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS.md b/NEWS.md index ebbef326..db003b42 100644 --- a/NEWS.md +++ b/NEWS.md @@ -7,6 +7,7 @@ - Added `FilterUnivariateCox` (thanks to @bblodfon) - Parameter value `na.rm` is properly initialized to `TRUE` (thanks to @bblodfon) - Bugfix: property `missings` is now set correctly for `FilterFindCorrelation` +- Bugfix: `$hash` now works for `Filter`s # mlr3filters 0.7.1