-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing filter / featsel methods #2
Comments
For the filters: I'd start with stats / no pkg, then try to connect the modern filter packages (FSelectorRcpp and praznik). We don't need 3 forest filters, we can solve this more generically by extending mlr3 learners with methods to extract feature scores. |
This is really important to be able to use all kinds of embedded feature selection directly by the learner. |
I don't really see a reason to use the Java FSelector package when there is FSelectoRcpp. |
The later does not have all filters of the former. See https://mlr.mlr-org.com/articles/tutorial/filter_methods.html. |
Well, with this argument we have to include all possible filters 😄 I would suggest we start without it, and if people complain/open issues we can still add them later. |
there never is (should be) pressure to include everything, include what is most important |
My comment was more meant to be a comparison, not a statement that we should do it :) |
NB: All learners which have some sort of "importance" are now supported via FilterVariableImportance. |
Filters
Pkg
No pkg
AUC
generic permutation
univariate.model.score
stats
anova
kruskal
linear.correlation
rank.correlation
variance
FSelector
Do we want to have these filters in again? Slow and Java problems..
FSelectorRcpp
Learner integrated filters
ranger.impurity
ranger.permutation
cforest.importance
Do we want to add the
ramdomForest
andrandomForestSRC
ones?mRMRe
- [ ] mrmr-> slow and no support for classif tasks mlr-org/mlr#2604praznik
CMIM
DISR
JMI
JMIM
MIM
MRMR
NJMIM
care
spFSR
Need to check.
Ensemble filters
Min
Mean
Median
Max
Borda
Borda-staircase
Borda-power
The text was updated successfully, but these errors were encountered: