Merge pull request #114 from mlr-org/crate_fix

get corret topenv() for crate()
mlr-org · Aug 8, 2024 · 36cac4a · 36cac4a
2 parents 932cc3f + 2d94a16
commit 36cac4a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -34,7 +34,7 @@ Config/testthat/parallel: true
 Encoding: UTF-8
 NeedsCompilation: yes
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.1
+RoxygenNote: 7.3.2
 Collate:
     'Dictionary.R'
     'named_list.R'

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # mlr3misc (development version)
 
+* Bugfix: `crate()` is using the correct 'topenv' environment now.
+
 # mlr3misc 0.15.1
 
 * refactor: Update `as_callback()` functions.

diff --git a/R/crate.R b/R/crate.R
@@ -28,7 +28,7 @@
 #' z = 300
 #' f = meta_f(1)
 #' f()
-crate = function(.fn, ..., .parent = topenv(), .compile = TRUE) {
+crate = function(.fn, ..., .parent = topenv(parent.frame()), .compile = TRUE) {
   assert_flag(.compile)
   .compile = .compile || is_compiled(.fn)
   nn = map_chr(substitute(list(...)), as.character)[-1L]

diff --git a/man/crate.Rd b/man/crate.Rd