Skip to content

Commit

Permalink
ML-4879: Avoid keeping reference to events in AggregateByKey when c…
Browse files Browse the repository at this point in the history
…ache is disabled (#463)

Fixes [ML-4879](https://jira.iguazeng.com/browse/ML-4879).

Co-authored-by: Gal Topper <[email protected]>
  • Loading branch information
gtopper and Gal Topper authored Nov 2, 2023
1 parent ca426ae commit 1ede8e3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion storey/table.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@ async def _aggregate(self, key, event, data, timestamp):
cache_item = self._get_aggregations_attrs(key)
await cache_item.aggregate(data, timestamp)
self._changed_keys.add(key)
self._pending_events.append(event)
if self._flush_task:
self._pending_events.append(event)

async def _get_features(self, key, timestamp):
if self._flush_exception is not None:
Expand Down

0 comments on commit 1ede8e3

Please sign in to comment.