Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Discord Canary version support #9

Open
RustemB opened this issue Jun 18, 2021 · 3 comments
Open

Add Discord Canary version support #9

RustemB opened this issue Jun 18, 2021 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@RustemB
Copy link

RustemB commented Jun 18, 2021

Would be nice, if you add flag or priority detection of any Discord versions
@mlvzk mlvzk added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 18, 2021
@LukasDoesDev
Copy link

On line 53 discord can be replaced with discordcanary but a flag or parameter would be nicer

@LukasDoesDev
Copy link

LukasDoesDev commented Aug 3, 2021 •
edited
Loading

The following line will take in the first parameter to the bash script. If the parameter does not exist the default "discord" is used:

discord_type=${1:-discord}

@RustemB
Copy link
Author

RustemB commented Aug 3, 2021

cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RustemB @mlvzk @LukasDoesDev