Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env_var: and command_line: from Options #1237

Open
wks opened this issue Nov 25, 2024 · 0 comments
Open

Remove env_var: and command_line: from Options #1237

wks opened this issue Nov 25, 2024 · 0 comments

Comments

@wks
Copy link
Collaborator

wks commented Nov 25, 2024

We used to have some items in mmtk::util::options::Options that can only be set via environment variables but not the command line, or vice versa. One example is MMTK_THREADS due to MMTk being initialized via lazy_static!. After we introduced MMTKBuilder, this restriction is removed.

Now all options can be set via both environment variables and command line. We may remove the redundant [env_var: true, command_line: true] from the options declaration. e.g. What we have now

    plan:                  PlanSelector         [env_var: true, command_line: true] [always_valid] = PlanSelector::GenImmix,
    threads:               usize                [env_var: true, command_line: true] [|v: &usize| *v > 0]    = num_cpus::get(),

will become

    plan:                  PlanSelector         [always_valid] = PlanSelector::GenImmix,
    threads:               usize                [|v: &usize| *v > 0]    = num_cpus::get(),
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant