Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add support for easy language switching #3

Open
SoulInfernoDE opened this issue Feb 1, 2019 · 14 comments
Open

[Feature request] Add support for easy language switching #3

SoulInfernoDE opened this issue Feb 1, 2019 · 14 comments

Comments

@SoulInfernoDE
Copy link

SoulInfernoDE commented Feb 1, 2019

Hi,
i have made a language pack for german. It would be very nice if there is any option to include/download the language pack and overwrite existing files with it from within either the launcher or from the snap itself.
If you have any idea how this could be done the smart way i could give you the link to the language pack and the references.

Way to manually download the language pack via terminal:
wget --no-check-certificate 'https://raw.githubusercontent.com/mzramna/easy-google-drive-downloader/master/download_google_drive_file.sh' -O download_google_drive_file.sh && chmod +x download_google_drive_file.sh && ./download_google_drive_file.sh '10gE3vUSUcjFWC0gxsnUbbLlZODffdydE'

Also i don't know if it's allowed to add the uncut patches from Nyerguds but this would fit the game in german language nearly the same as in english and has a very nice play feeling.

@mmtrt
Copy link
Owner

mmtrt commented Feb 2, 2019

I could implement this into the snap with following possible ways. I like the third option.

  • detect user lang using on the distro if it matches GER then do the magic.
  • add a var flag to snap when user run snap with flag then do the magic.
  • add options on game type selection screen showing install game with unofficial GER translation.

can you post contents of tar file I have slow connection could take time, so the lang pack is for full game not for multiplayer of cncnet client if I'm correct.

@SoulInfernoDE
Copy link
Author

SoulInfernoDE commented Feb 2, 2019

Yes i think the third option would be a good solution. You are right it's a full game translation including the firestorm expansion. This includes a sound, text and video translation. You mentioned a good point that not all people have a fast internet connection. So adding a second option that only translates core parts of the game without the bigger files which excludes videos for example would be a good thing. I'll make a second archive excluding the bigger files.

First here are the folder containing all of the files including a screenshot of the contents:
https://drive.google.com/drive/folders/1ExLoLW1hHbHxexHTJg4n8frwPPpUC7n7?usp=sharing

Full german language pack contents [~1.4GB]:
content_of_cnctsf_uncut_language_pack_german_tar_bz2
Explanation of some files:
ecache81.mix - The Patch from Zimbio81 uncuts the cyborgs.
MOVIES01-03.MIX - translates the movies to german
TIBSUN.MIX ->All other files - translates everything possible with a language pack

Small german language pack - excluding any media contents [~102MB]:
contents_of_cnctsf_uncut_language_pack_german_small_tar_bz2

Manual download of the small language pack in terminal:
wget --no-check-certificate 'https://raw.githubusercontent.com/mzramna/easy-google-drive-downloader/master/download_google_drive_file.sh' -O download_google_drive_file.sh && chmod +x download_google_drive_file.sh && ./download_google_drive_file.sh '1yNuqd7v_mGIXaEWVipG_JKaCLO_JfRK_' && rm download_google_drive_file.sh

If anyone encounters errors, missing translation scenes, crashes or bugs regarding the language pack, feel free to report them here or offer a fixed version/a fix here. I will help to fix them as far as i could with the mod tools that are available out there.

mmtrt added a commit that referenced this issue Feb 4, 2019
This adds core and complete lang packs. fixes #3
@mmtrt
Copy link
Owner

mmtrt commented Feb 4, 2019

@SoulInfernoDE can you test the changes I've just added are living on edge channel.

snap install --edge cnctsun

or update the snap

snap refresh --edge cnctsun

I've only tested core lang pack option.

@SoulInfernoDE
Copy link
Author

SoulInfernoDE commented Feb 5, 2019

i have attached the debug log from installing with the terminal after snap is installed.

I commented commit dc72b63

--> I have tested the full language pack method <--
debug05022019_snap_cnctsun_edge_ger_full.txt

@mmtrt
Copy link
Owner

mmtrt commented Feb 6, 2019

Retest the snap from edge and confirm it.

@SoulInfernoDE
Copy link
Author

SoulInfernoDE commented Feb 6, 2019

commented d0cfecc

Edit: It could download the language pack. However it throws permission denied anyway but it downloaded successfully on my linux mint laptop anyways. Im not sure if this was luck or if it will work every time. One bug is left. The language pack is in a folder inside of the installation folder. We need to move and overwrite the existing files. Either i should repack and reupload the language pack or moved per script?

@mmtrt
Copy link
Owner

mmtrt commented Feb 7, 2019

That permission issue is harmless as for lang pack you should repack and upload it then test confirm so that I push out build from edge to stable.

@SoulInfernoDE
Copy link
Author

Hey mmtrt,
i tried to delete everything left on my computer and then reinstalled after i reuploaded the repackaged language pack. It works like a charm! THANK YOU! 🥇

There are one or two notes we should give users who want to install the full game version:

  • They should NOT select: "Install movies and audio" from the Installer as the files will be double downloaded first in english then in german and then it will be overwritten. So downloading the english versions isn't necessary anymore.
  • The Installation of the language pack can take approx. ~6 minutes. This is due to the high compression of the language pack in .bz2-format. Packing in this format has good compatibility and saved approx. ~330 MB of downloading without compression.

So if you are willing to further support this i could upload a language pack for Spanish and French, too. So everyone will be pleased :-)

@mmtrt
Copy link
Owner

mmtrt commented Feb 7, 2019

yeah do that then post their link ids so I'll add them, I could remove the silent install flag from lang pack install option so users could freely select files.

@SoulInfernoDE
Copy link
Author

So the snap installation process of the full language packs will be:

  • install the snap ->
  • wine will be auto-configured ->
  • install Tiberian Sun with TSInstaller but unselect "Install Movies" and unselect "Install Audio" in TSInstaller ->
  • full language pack will download, extract and overwrites existing files.

Language pack for french is ready:

Language pack for spanish is ready:

-> I recommend renaming the first entry: Full Game to something like: [English] Full Game (Singleplayer + Multiplayer) so users would recognize that there are options for their language available
"Full Game (Singleplayer + Multiplayer)" "Multiplayer" "Core translation GER unofficial with full game" "Complete translation GER unofficial with full game")

@mmtrt
Copy link
Owner

mmtrt commented Feb 8, 2019

can you test new changes though I'll add the notice warn users before install later after some testings.

@SoulInfernoDE
Copy link
Author

Tested and commented commit 6e24c2b
-> Only first option: "English - Full Game" seems to work yet.

@mmtrt
Copy link
Owner

mmtrt commented Feb 11, 2019

9b2d439 should fix that issue.

@SoulInfernoDE
Copy link
Author

SoulInfernoDE commented Feb 12, 2019

I am testing right now all options from start to end. Adding final statement soon.

Edit: All seems to be working fine now!

You Sir @mmtrt are genius! Thanks for Crafting!

Note: would be nice if you could do the small change requested in mmtrt/cncra repo :-)

Edit: You can push it to stable channel if you like to 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants