-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Add support for easy language switching #3
Comments
I could implement this into the snap with following possible ways. I like the third option.
can you post contents of tar file I have slow connection could take time, so the lang pack is for full game not for multiplayer of cncnet client if I'm correct. |
Yes i think the third option would be a good solution. You are right it's a full game translation including the firestorm expansion. This includes a sound, text and video translation. You mentioned a good point that not all people have a fast internet connection. So adding a second option that only translates core parts of the game without the bigger files which excludes videos for example would be a good thing. I'll make a second archive excluding the bigger files. First here are the folder containing all of the files including a screenshot of the contents: Full german language pack contents [~1.4GB]: Small german language pack - excluding any media contents [~102MB]: Manual download of the small language pack in terminal: If anyone encounters errors, missing translation scenes, crashes or bugs regarding the language pack, feel free to report them here or offer a fixed version/a fix here. I will help to fix them as far as i could with the mod tools that are available out there. |
This adds core and complete lang packs. fixes #3
@SoulInfernoDE can you test the changes I've just added are living on edge channel.
or update the snap
I've only tested core lang pack option. |
i have attached the debug log from installing with the terminal after snap is installed. I commented commit dc72b63 --> I have tested the full language pack method <-- |
Retest the snap from edge and confirm it. |
commented d0cfecc Edit: It could download the language pack. However it throws permission denied anyway but it downloaded successfully on my linux mint laptop anyways. Im not sure if this was luck or if it will work every time. One bug is left. The language pack is in a folder inside of the installation folder. We need to move and overwrite the existing files. Either i should repack and reupload the language pack or moved per script? |
That permission issue is harmless as for lang pack you should repack and upload it then test confirm so that I push out build from edge to stable. |
Hey mmtrt, There are one or two notes we should give users who want to install the full game version:
So if you are willing to further support this i could upload a language pack for Spanish and French, too. So everyone will be pleased :-) |
yeah do that then post their link ids so I'll add them, I could remove the silent install flag from lang pack install option so users could freely select files. |
So the snap installation process of the full language packs will be:
Language pack for french is ready:
Language pack for spanish is ready:
-> I recommend renaming the first entry: Full Game to something like: [English] Full Game (Singleplayer + Multiplayer) so users would recognize that there are options for their language available |
can you test new changes though I'll add the notice warn users before install later after some testings. |
Tested and commented commit 6e24c2b |
9b2d439 should fix that issue. |
I am testing right now all options from start to end. Adding final statement soon. Edit: All seems to be working fine now! You Sir @mmtrt are genius! Thanks for Crafting! Note: would be nice if you could do the small change requested in mmtrt/cncra repo :-) Edit: You can push it to stable channel if you like to 👍 |
Hi,
i have made a language pack for german. It would be very nice if there is any option to include/download the language pack and overwrite existing files with it from within either the launcher or from the snap itself.
If you have any idea how this could be done the smart way i could give you the link to the language pack and the references.
Way to manually download the language pack via terminal:
wget --no-check-certificate 'https://raw.githubusercontent.com/mzramna/easy-google-drive-downloader/master/download_google_drive_file.sh' -O download_google_drive_file.sh && chmod +x download_google_drive_file.sh && ./download_google_drive_file.sh '10gE3vUSUcjFWC0gxsnUbbLlZODffdydE'
Also i don't know if it's allowed to add the uncut patches from Nyerguds but this would fit the game in german language nearly the same as in english and has a very nice play feeling.
The text was updated successfully, but these errors were encountered: