-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary null pointer checks #857
Comments
All these are very good catches. Thanks. Would you be willing to PR the changes? |
💭 Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments? How do you think about to adjust any more source code places? 🤔 |
Yes, we use it. |
How do you think about to improve the software situation any more by influencing evolution according to development tools for automatic source code adjustments? 🤔 |
That's a good idea. But I think that the chances of a fix generating more harm than good are, in my opinion too high. Our testing pipeline, or our coverage, aren't in great either. So it would mean that it would be hard to catch the generated problem. |
Search patterns can be specified for questionable source code places. |
Extra null pointer checks are not needed in functions like the following.
The text was updated successfully, but these errors were encountered: