Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add is-clipped class to <html> tag when any modal is open and when the menu is open on touch #50

Closed
SebConejo opened this issue Aug 2, 2023 · 0 comments
Closed

add is-clipped class to <html> tag when any modal is open and when the menu is open on touch #50

SebConejo opened this issue Aug 2, 2023 · 0 comments
Assignees
@brunobuddy

Comments

@SebConejo
Copy link
Contributor

SebConejo commented Aug 2, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
To date, when the menu is open on touch versions or when a modal is open on any devis, the user still can scroll down. The app looks "broken".
Capture d’écran 2023-08-02 à 14 18 04

Describe the solution you'd like
When those elements are open, the html tag should get the class is-clipped.

  • Side menu on touch devices
  • Modal dialogs.

Additional context
Le CSS fonctionne déjà. Cela signifie que l'ajout de la classe devrait permettre à la fonctionnalité de fonctionner instantanément
@SebConejo SebConejo added this to the CASE MVP milestone Aug 2, 2023
@github-project-automation github-project-automation bot moved this to Todo in Manifest Aug 2, 2023
@brunobuddy brunobuddy moved this from Todo to Done in Manifest Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunobuddy brunobuddy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brunobuddy @SebConejo