Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TA-x model reproduction. #3

Open
mer1988 opened this issue Sep 11, 2019 · 6 comments
Open

TA-x model reproduction. #3

mer1988 opened this issue Sep 11, 2019 · 6 comments

Comments

@mer1988
Copy link

mer1988 commented Sep 11, 2019

Hi Alberto, I have been trying for a while to replicate the results from the time aware link prediction paper using the published datasets using the re-implementation of your models from this repo, https://github.com/INK-USC/RE-Net I have carefully looked into the code it looks reasonable to your implementation. The only change I have made from this code and my version is that I change the way they calculate filter hits@10 -> they suppress every object from the ranked list that is observed in training/validation regardless of the time when it occurred while I only suppress those observed in the same timestamp, otherwise I keep it.

The best results I have gotten so far are

  | MRR . | H1 | H10
TA-DistMult | 0.351600377 | 0.2187883521 | 0.628807319
TA-TransE | 0.2173162281 | 0 | 0.6098404552

Do you have any thoughts?? or maybe an accessible implementation of your model?

Thanks!

@mniepert
Copy link
Owner

Dear Miguel,

Could you provide more context? What dataset is this? One difference in the code that I noticed is that they only use one negative sample (and binary crossentropy) and we use 500 negative samples. This has been shown to make a huge difference for scoring functions such as DistMult.

@mer1988
Copy link
Author

mer1988 commented Sep 11, 2019

Thanks Mathias,
I will take a look a close look at neg sampling. The results I show are for the icews14 dataset published in this repo.

Miguel R.

@AGDuran
Copy link
Collaborator

AGDuran commented Sep 11, 2019 via email

@mer1988
Copy link
Author

mer1988 commented Sep 11, 2019

Hi Alberto, I apply the filter for all metrics. Thanks for the neg sampling suggestion, that I had totally missed.

@mer1988
Copy link
Author

mer1988 commented Sep 25, 2019

Hi Alberto, is there any possibility to use your implementation of the TA-xx models for research purposes?

@AGDuran
Copy link
Collaborator

AGDuran commented Sep 26, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants