Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NormalizeFilePath, infinite loop #1074

Open
ghost opened this issue Mar 8, 2015 · 2 comments
Open

NormalizeFilePath, infinite loop #1074

ghost opened this issue Mar 8, 2015 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented Mar 8, 2015

https://github.com/moai/moai-dev/blob/develop/src/zl-vfs/ZLVfsFileSystem.cpp#L506
I do not know if the code is finished, so I will not change.
Anyway I report that the variable 'k' is unsigned

size_t k ; // unsigned

Then the following conditional is always true:

k >= 0

This will cause an infinite loop.

@makotok
Copy link
Member

makotok commented Mar 9, 2015

This will be an infinite loop.
Need to be modified.

@ghost
Copy link
Author

ghost commented Mar 11, 2015

In my test, k >= 0 should stay.
Change to int k or long k should suffice.

@halfnelson halfnelson added the Bug label Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants