Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to make windows build work again #1216

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Fixes to make windows build work again #1216

merged 2 commits into from
Jul 23, 2019

Conversation

sshukul
Copy link
Contributor

@sshukul sshukul commented Jul 18, 2019 •
edited
Loading

  1. Migrated sln and vcxproj files to Visual Studio 2019 to keep everything up to date. Changed directory name accordingly and added its build dirs to gitignore.
  2. Fixed some compilation errors specific to the visual studio c++ compiler such as ambiguous casts, unused variables with duplicate names, typos and missed headers.
  3. Modified the sdl, zlib and expat vcxproj projects to point to the new versions that have been updated in the 3rdparty directory. Add / remove new file references into the respective projects from within the new version directories as required for compilation and linking.
  4. Flipped "treat warning as error" flags in some projects since there are some more warnings since moai 2.0 upgrade that were failing windows build otherwise.
  5. Removed LuaJIT project references since it is currently unused in moai 2.0.
  6. Added the necessary ZLIB_DEBUG flag in the new zlib project to get the debug builds to compile correctly. This is not added in the release builds.

@patrickmeehan patrickmeehan merged commit 0b734f5 into moai:develop Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sshukul @patrickmeehan @saurabh-shukul-gojek