Addressing PR Feedback

Noted that 'bundle' is optional and has a default value Set 'bundle' to null if a value is not given
mobify · Jul 14, 2017 · 2138d48 · 2138d48
1 parent 7a5168c
commit 2138d48
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -187,7 +187,7 @@ The `preview` command uses http://preview.mobify.com to open a website specified
 Parameter Name | Parameter Type | Description
 -------------  | -------------- | -----------
 url            | String         | The URL to preview, equivalent to the Site URL field. 
-bundle         | String         | The bundle URL, equivalent to the Bundle Location field.
+bundle         | String         | _optional_ The bundle URL, equivalent to the Bundle Location field. Default is `https://localhost:8443/loader.js`
 callback       | Function       | _optional_ A function to call after the current command finishes execution.  
 
 ```

diff --git a/commands/preview.js b/commands/preview.js
@@ -28,7 +28,7 @@ exports.command = function(url, bundle, callback) {
 
     if (typeof bundle === 'function') {
         callback = bundle;
-        bundle = '';
+        bundle = null;
     }
 
     var bundleUrl = bundle || 'https://localhost:8443/loader.js';