Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Pinny should close when the browser back button is pressed #16

Open
kpeatt opened this issue Sep 2, 2014 · 4 comments
Open

Pinny should close when the browser back button is pressed #16

kpeatt opened this issue Sep 2, 2014 · 4 comments

Comments

@kpeatt
Copy link
Contributor

kpeatt commented Sep 2, 2014

We've been getting user feedback that users expect to be able to close Pinny by pressing the browser back button on their device. This means that instead of navigating back a page, we should just close Pinny on back.

From a user's perspective, tapping back twice is easy if they want to go back a page. It is more annoying to accidentally go back a page when you don't expect to.

@kpeatt kpeatt added this to the Pinny 1.0 milestone Sep 2, 2014
@kpeatt kpeatt modified the milestones: Post Pinny 1.0, Pinny 1.0 Sep 8, 2014
@kpeatt kpeatt modified the milestone: Post Pinny 1.0 Nov 12, 2014
@scalvert
Copy link
Contributor

I think we should talk about this one again. It's never come up in any feedback that I know of. If we don't need it, let's not add it!

@kpeatt
Copy link
Contributor Author

kpeatt commented Feb 2, 2015

In my UX opinion, we should add it. It's more frustrating to lose the page when you have an unknown full screen overlay than it is to have to hit back twice.

@scalvert
Copy link
Contributor

scalvert commented Feb 2, 2015

I feel like this should be reserved for when someone actually logs an issue. We should take care to only 'fix' what needs fixing. If we try to fix too much, we'll end up with a bloated plugin! Thoughts?

@kpeatt
Copy link
Contributor Author

kpeatt commented Feb 2, 2015

This is more like a feature than a fix though — I don't think it would cost too many lines to add either.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants