Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish TOB-5 remediations #3189

Open
cbeck88 opened this issue Feb 28, 2023 · 0 comments
Open

Finish TOB-5 remediations #3189

cbeck88 opened this issue Feb 28, 2023 · 0 comments
Assignees
@cbeck88
Labels
consensus Related only to the consensus protocol or service remediation Issue: Postmortem remediation security Public issues which impact security impact tech-debt Technical debt payment

Comments

@cbeck88
Copy link
Contributor

cbeck88 commented Feb 28, 2023

This follows up on: #2313

In block version 3, we made fee_map_digest an optional member of Tx, and if present, the enclave confirms it when it does the well-formedness check.

Eventually this should be mandatory.
-[ ] make fee map digest mandatory
-[ ] add this field to signing_data object created by tx builder
-[ ] notify copper and any other partners

I suggest, Let's not do this before block version 6 to avoid churn for copper
@cbeck88 cbeck88 added tech-debt Technical debt payment remediation Issue: Postmortem remediation security Public issues which impact security impact consensus Related only to the consensus protocol or service labels Feb 28, 2023
@cbeck88 cbeck88 self-assigned this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbeck88 cbeck88

Labels
consensus Related only to the consensus protocol or service remediation Issue: Postmortem remediation security Public issues which impact security impact tech-debt Technical debt payment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cbeck88