Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Break Damage] Include the 3rd strike break damage bonus #1

Open
brebory opened this issue Dec 6, 2017 · 0 comments
Open

[Break Damage] Include the 3rd strike break damage bonus #1

brebory opened this issue Dec 6, 2017 · 0 comments
Labels
Milestone

Comments

@brebory
Copy link
Contributor

brebory commented Dec 6, 2017

Overview

The target break damage calculation currently does not include the target break damage bonus. The method and formula are explained here:
https://docs.google.com/document/d/1lmxiazuHfNv_e2KU4MEAhe1L2KGPqyLtvyC8bCHbBUw/edit

Implementation

The break damage should be factored in by injecting an extra modifier into break damage calculation on every third tap. This modifier should multiply the break damage by a value of 1.1. A new ModifierTrait will probably have to be created to support this cleanly - I'm thinking adding a Miscellaneous flag and combining Miscellaneous and Independent for all unique independent modifiers like this.

@brebory brebory added this to the v1.0.0 milestone Dec 14, 2017
@brebory brebory added the bug label Dec 14, 2017
@brebory brebory changed the title Modify the target break damage calculation to include the 3rd strike break damage bonus [Break Damage] Include the 3rd strike break damage bonus Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant