Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyliusExportPlugin VS SyliusImportExportPlugin #1

Open
oallain opened this issue Feb 27, 2020 · 6 comments
Open

SyliusExportPlugin VS SyliusImportExportPlugin #1

oallain opened this issue Feb 27, 2020 · 6 comments

Comments

@oallain
Copy link

oallain commented Feb 27, 2020

Hello,

What feature does this plugin provide compared to https://github.com/FriendsOfSylius/SyliusImportExportPlugin?

Thanks

@smildev
Copy link
Member

smildev commented Feb 27, 2020

Hello,

This plugin only provide export of sylius resources.
The main difference is that it automatically add a new bulkAction to all sylius resources.
Each sylius resource has a new 'bulkAction' and a new route (ex: sylius_admin_customers_bulk_export).

It also provide a new bulkAction 'export' to the grid.

For the moment there is only 'csv' export.
Exported resources are filtered by the grid.
It also use the grid to define exported fields.

The documentation (and some improvements) will be available in following days.

@oallain
Copy link
Author

oallain commented Feb 27, 2020

Hi @smildev ,

Interesting 👍 , it would have been cool if it were integrated into the already existing plugin, what do you think?

@smildev
Copy link
Member

smildev commented Feb 27, 2020

I think it could be defined as a new ResourceImporter.

First, I want to release a stable version with doc in the following days.
After, I could work to integrate it with SyliusImportExport plugin.

@oallain
Copy link
Author

oallain commented Feb 27, 2020

Nice ! I can help you for integration.

@smildev
Copy link
Member

smildev commented Apr 29, 2020

Hi @oallain !
What kind off integration were you thinking off ?

I think i can't integrate this plugin in yours (due to exporter difference).

Maybe i can add the same new 'bulkExportAction' and add a new GridResourceExporter compatible with your "Exporter pattern" ?

@oallain
Copy link
Author

oallain commented Apr 29, 2020

Hi @smildev,

Yeah, IMO add the same new 'bulkExportAction' and add a new GridResourceExporter compatible with SyliusImportExportPlugin "Exporter pattern" is a good idea 👍

Your way of exporting and that of SyliusImportExportPlugin are not incompatible. They are even complementary because they do not export exactly the same data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants