Tweak principia_make.sh cmake flags #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ultimately this should really use gtest.
…h step of 1 makes perfect sense, on the other hand a negative step would cause trouble.
principia_make
CMAKE_LD_FLAGS isn't recognized by CMake:
CMake Warning:
Manually-specified variables were not used by the project:
CMAKE_LD_FLAGS
No replacement is needed since static libraries are created for
consumption by Principia and those use ar instead of ld.
"." is added to the command line to future-proof the command against
future CMake releases:
CMake Warning:
No source or binary directory provided. Both will be assumed to be the
same as the current working directory, but note that this warning will
become a fatal error in future CMake releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_LD_FLAGSisn't recognized by CMake:No replacement is needed since static libraries are created for
consumption by Principia and those use
arinstead ofld."." is added to the command line to future-proof the command against
future CMake releases: