Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or add missing premake workaround #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danielappelt
Copy link

No description provided.

@falkTX
Copy link
Member

falkTX commented Nov 16, 2020

Thanks, but this is not quite right.
it should set PREMAKE var only if it is not in the path, so you can do instead something like:

if ! which premake > /dev/null; then
    if [ ! -f premake ]; then
        wget ...
    fi
    PREMAKE=...
fi

@danielappelt
Copy link
Author

Thank you for your feedback. I just applied the same logic as is currently present in distrho-ports-labs. Does it need to be changed there too (and possibly for other plugins that use the same patch)? It worked just fine here with the given commit..

@danielappelt
Copy link
Author

The pull request now covers all premake patches. @falkTX, could you check again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants