Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase modal-client type coverage #1372

Open
savarin opened this issue Feb 20, 2024 · 1 comment
Open

Increase modal-client type coverage #1372

savarin opened this issue Feb 20, 2024 · 1 comment

Comments

@savarin
Copy link
Contributor

savarin commented Feb 20, 2024

This is an umbrella issue created to add types to modal-client.

We expect changes to be made in two stages:

  1. Expand type coverage to allow mypy to pass beyond the existing check on .pyi stubs.
  2. Implement strict type checking, as well as remove Any and type ignores (where possible) above.

Existing dependency tree as generated with pydeps and the following .pydeps file.

[pydeps]
pylib = False
exclude =
    aiohttp
    aiostream
    aiostream
    asgiref
    click
    cloudpickle
    dotenv
    fastapi
    grpclib
    ipykernel
    rich
    synchronicity
    tblib
    toml
    typer
    typing_extensions
    watchfiles

modal

@zsiegel92
Copy link
Contributor

zsiegel92 commented Aug 23, 2024

Hey @savarin or @freider FYI I opened this related PR and filed this related issue.

If you have any availability to chip away at this I'll be so grateful! 🙏 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants