Add type to more util modules #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savarin
commented
Mar 24, 2024
|
|
||
| def generator(rand): | ||
| return rand.choice(enum_values) | ||
| generator = lambda rand: rand.choice(enum_values) # noqa: E731 |
There was a problem hiding this comment.
@freider I added a ruff ignore here to avoid having a def, which requires a function type signature and conflicts vs line 64.
savarin
force-pushed
the
include-types-4
branch
2 times, most recently
from
7ad5e06
to
f0aaa9b
Compare
|
@freider Let me know if you have comments, thanks! |
savarin
force-pushed
the
include-types-4
branch
from
f0aaa9b
to
939f74f
Compare
mwaskom
approved these changes
Mar 29, 2024
| @@ -12,6 +12,7 @@ def _update(hashers, data: Union[bytes, IO[bytes]]): | |||
| for hasher in hashers: | |||
| hasher.update(data) | |||
| else: | |||
| assert isinstance(data, IO) | |||
There was a problem hiding this comment.
Odd that this is necessary!
There was a problem hiding this comment.
It turns out to be microsoft/pyright#5697
Also this broke our CI once it landed which is weird because it looks like it passed on the branch 🤔
There was a problem hiding this comment.
@mwaskom My bad for delay, had been deep in interview-land 😅
There was a problem hiding this comment.
No worries, I got to learn some interesting stuff about typing edge cases :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds mypy types to more
_utilsmodules, as per #1372.