Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire modal-client PyPI package: Step two #2557

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Nov 21, 2024

Followup to #2556

Removes the "alias-package" stuff from our CD pipeline.

Closes CLI-258

@mwaskom mwaskom changed the title Michael/retire modal client step two Retire modal-client: Step two Nov 21, 2024
@mwaskom mwaskom changed the title Retire modal-client: Step two Retire modal-client PyPI package: Step two Nov 21, 2024
@mwaskom mwaskom force-pushed the michael/retire-modal-client-step-two branch from a06c1d9 to b1c3eb6 Compare November 21, 2024 22:34
@mwaskom
Copy link
Contributor Author

mwaskom commented Nov 21, 2024

@prbot approve; just removes vestigial deployment steps

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @erikbern will follow-up review this.

Copy link
Contributor

@erikbern erikbern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@mwaskom mwaskom merged commit c5bb31c into main Nov 21, 2024
21 checks passed
@mwaskom mwaskom deleted the michael/retire-modal-client-step-two branch November 21, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants