Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split add_object into add_function and add_class #2586

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

erikbern
Copy link
Contributor

Minor chore for the 1.0 – I want to split up a bunch of old stuff related to indexed_objects now that it's only ever functions or classes

@erikbern erikbern force-pushed the erikbern/split-add-object branch from c748764 to 8b2f9ee Compare November 28, 2024 15:08
@erikbern erikbern force-pushed the erikbern/split-add-object branch from 8b2f9ee to fabe5b7 Compare November 28, 2024 15:29
@erikbern erikbern requested review from mwaskom and freider November 28, 2024 15:38
Copy link
Contributor

@freider freider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
We'll probably get rid of global class hydration soon anyways (classes don't have their own backend data now and all info is in their class_service_function), so I expect the class part of this to go away then too, making this even cleaner

@erikbern erikbern merged commit d4f8c25 into main Nov 29, 2024
22 checks passed
@erikbern erikbern deleted the erikbern/split-add-object branch November 29, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants