Skip to content

Make HDF5 optional #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
milancurcic opened this issue Aug 13, 2024 · 1 comment
Closed

Make HDF5 optional #186

milancurcic opened this issue Aug 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@milancurcic
Copy link
Member

It's a tedious dependency to build with across compilers and is only used for input from Keras models which not many users need. Put HDF5 code behind CPP macros and make it optional at build time.
@milancurcic milancurcic added the enhancement New feature or request label Aug 13, 2024
@milancurcic milancurcic mentioned this issue Aug 21, 2024
Closed
2 tasks
@milancurcic
Copy link
Member Author

Done by #188. Keras HDF5 adapter is now in https://github.com/neural-fortran/nf-keras-hdf5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make HDF5 optional under CMake milancurcic/neural-fortran
1 participant
@milancurcic