Skip to content

Implement recurrent layers #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricor07 opened this issue Feb 24, 2025 · 4 comments
Open

Implement recurrent layers #206

ricor07 opened this issue Feb 24, 2025 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ricor07
Copy link
Collaborator

ricor07 commented Feb 24, 2025

Particularly, RNN, SimpleRNN, LSTM, and GRU.

@ricor07 ricor07 added the enhancement New feature or request label Feb 24, 2025
@ricor07 ricor07 self-assigned this Feb 24, 2025
@milancurcic
Copy link
Member

There is a WIP basic RNN PR here: #162

Not sure how much it's reusable, or its current state, @castelao may chime in.

@ricor07
Copy link
Collaborator Author

ricor07 commented Mar 7, 2025

Do you mind if I start working on @castelao 's fork? Of course he will be cited

@castelao
Copy link
Collaborator

Hi everyone. I'm sorry for the slow response and thanks for checking.

I had the RNN working back in 2023 and did use it, but I don't remember anymore why we didn't conclude and merged that. I think that main received some changes and diverged from my fork and I didn't have the chance to conform. I would be excited to see RNN implemented in main, even better with LSTM and all the other variations. If what I did is helpful, please take it and move it forward, otherwise, fell free to close that branch and do it on your way. Whatever @milancurcic thinks is the most efficient and better way to move forward, works for me.

Tomorrow evening I'll look in my archives to remind myself what I did and update #162 with what I find.

@milancurcic
Copy link
Member

Thanks @castelao, no worries. The main reason why I didn't push it to conclusion yet was because it remained marked as draft so I thought the design was still changing. Getting that PR up to speed should be easy (and I can do it too, if needed). Just mark it as ready for review if you think it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants