From 6227eafc097472784eb4fbfac4e03266d253fc52 Mon Sep 17 00:00:00 2001
From: Vitalii Saienko <vsaienko@atlassian.com>
Date: Tue, 3 Sep 2019 17:04:31 +0300
Subject: [PATCH] Fix "getItem" is not a function

---
 __tests__/SafeStorage.js | 40 ++++++++++++++++++++++++++++++++++++++--
 src/SafeStorage.js       | 24 ++++++++++++++++++++++++
 2 files changed, 62 insertions(+), 2 deletions(-)

diff --git a/__tests__/SafeStorage.js b/__tests__/SafeStorage.js
index c0baa80..ca21f35 100644
--- a/__tests__/SafeStorage.js
+++ b/__tests__/SafeStorage.js
@@ -38,6 +38,19 @@ describe('SafeStorage', () => {
     expect(safeLocalStorage.isNativeStorageUsed).toBe(true)
     expect(safeLocalStorage.isInMemoryStorageUsed).toBe(false)
     expect(safeLocalStorage._options).toMatchSnapshot()
+
+    safeLocalStorage.setItem('test-1', 423)
+    safeLocalStorage.setItem('test-2', 481)
+    expect(safeLocalStorage.getItem('test-1')).toBe('423')
+    expect(safeLocalStorage.getItem('test-3')).toBe(null)
+    expect(safeLocalStorage.key(0)).toBe('test-1')
+
+    safeLocalStorage.removeItem('test-1')
+    expect(safeLocalStorage.key(0)).toBe('test-2')
+    expect(safeLocalStorage.length).toBe(1)
+
+    safeLocalStorage.clear()
+    expect(safeLocalStorage.length).toBe(0)
   })
 
   test('Use native sessionStorage', () => {
@@ -47,6 +60,19 @@ describe('SafeStorage', () => {
     expect(SafeStorage.isNativeStorageSupported('sessionStorage')).toBe(true)
     expect(safeSessionStorage.isNativeStorageUsed).toBe(true)
     expect(safeSessionStorage.isInMemoryStorageUsed).toBe(false)
+
+    safeSessionStorage.setItem('test-1', 423)
+    safeSessionStorage.setItem('test-2', 481)
+    expect(safeSessionStorage.getItem('test-1')).toBe('423')
+    expect(safeSessionStorage.getItem('test-3')).toBe(null)
+    expect(safeSessionStorage.key(0)).toBe('test-1')
+
+    safeSessionStorage.removeItem('test-1')
+    expect(safeSessionStorage.key(0)).toBe('test-2')
+    expect(safeSessionStorage.length).toBe(1)
+
+    safeSessionStorage.clear()
+    expect(safeSessionStorage.length).toBe(0)
   })
 
   test('Pass custom error message', () => {
@@ -57,7 +83,7 @@ describe('SafeStorage', () => {
   })
 
   test('Handle AccessDenied error', () => {
-    const errorMessage =
+    const domExceptionMessage =
       'Uncaught DOMException: Failed to read the "localStorage" property from "Window": Access is denied for this document.'
 
     delete global.window
@@ -65,7 +91,7 @@ describe('SafeStorage', () => {
     global.window = new Proxy(previousWindow, {
       get(obj, prop) {
         if (['localStorage', 'sessionStorage'].includes(prop)) {
-          throw new Error(errorMessage)
+          throw new Error(domExceptionMessage)
         }
 
         if (prop in obj) {
@@ -81,11 +107,21 @@ describe('SafeStorage', () => {
     expect(safeLocalStorage.isInMemoryStorageUsed).toBe(false)
     expect(safeLocalStorage.isNativeStorageUsed).toBe(false)
     expect(SafeStorage.isNativeStorageSupported('localStorage')).toBe(false)
+    expect(console.warn).toHaveBeenLastCalledWith(
+      'Looks like you\'ve disabled "localStorage". Enable it to avoid this warning.'
+    )
 
     const safeSessionStorage = createSafeSessionStorage()
 
     expect(safeSessionStorage.isInMemoryStorageUsed).toBe(true)
     expect(safeSessionStorage.isNativeStorageUsed).toBe(false)
     expect(SafeStorage.isNativeStorageSupported('sessionStorage')).toBe(false)
+    expect(console.warn).toHaveBeenLastCalledWith(
+      'Looks like you\'ve disabled "sessionStorage". Enable it to avoid this warning.'
+    )
+
+    const errorMessage = 'Custom error message'
+    createSafeLocalStorage({ errorMessage })
+    expect(console.warn).toHaveBeenLastCalledWith(errorMessage)
   })
 })
diff --git a/src/SafeStorage.js b/src/SafeStorage.js
index 319e3e1..ca6d046 100644
--- a/src/SafeStorage.js
+++ b/src/SafeStorage.js
@@ -57,4 +57,28 @@ export default class SafeStorage {
   get isInMemoryStorageUsed() {
     return Boolean(this._isInMemoryStorageUsed)
   }
+
+  getItem(key) {
+    return this._storage.getItem(key)
+  }
+
+  setItem(key, value) {
+    return this._storage.setItem(key, value)
+  }
+
+  removeItem(key) {
+    return this._storage.removeItem(key)
+  }
+
+  key(index) {
+    return this._storage.key(index)
+  }
+
+  clear() {
+    return this._storage.clear()
+  }
+
+  get length() {
+    return this._storage.length
+  }
 }