GH-152: Use ES-module import syntax #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMDJojo
force-pushed
the
cmdjojo/GH-152/0
branch
from
18a4bfb to
329970e
Compare
|
|
This does work on Firefox 111.0 (beta) but is locked behind the |
|
Confirmed to still be locked behind that flag on Firefox 111.0 Stable Release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
compiler.jsto import the bindings using the more modern ES-module syntax. This is supported by all major browsers but Firefox, which will get it in version 111, released March 14th. After we confirm that this works, we should thus merge this PR.It also changes
main.jsto have the extensionmjsfor JavaScript module, needed for support in MacOS.Resolves GH-152