Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

lib: provide a correct implementation for parsing semvar tags #34

Open
shoenig opened this issue Sep 8, 2018 · 4 comments
Open

lib: provide a correct implementation for parsing semvar tags #34

shoenig opened this issue Sep 8, 2018 · 4 comments

Comments

@shoenig
Copy link
Contributor

shoenig commented Sep 8, 2018

A few bits of code chop strings up to get at version strings, implement this correctly in the library so we can reuse the code

@billsmith
Copy link
Contributor

I'll look into using hashicorp/go-version for this.

@shoenig
Copy link
Contributor Author

shoenig commented Sep 9, 2018

There's a rudimentary version here:
https://github.com/modprox/taggit/blob/master/tag.go#L10

however it doesn't capture the "extensions" (? i dunno what else to call them) that semver annoyingly supports. See sections 9 and 10 of the semver guidelines: https://semver.org/
If hashicorp/go-version supports that stuff, great! Otherwise we do need to take those versioning things into account, for correct module version resolution in the proxy.

@billsmith
Copy link
Contributor

Judging by the unit tests, sections 9 and 10 are covered: https://github.com/hashicorp/go-version/blob/master/version_test.go

@billsmith
Copy link
Contributor

Sorry, I won't have time to work on this any time soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants