fix(devtools): fix options undefined cause error (#2401)

module-federation · Apr 28, 2024 · 99b23f7 · 99b23f7
1 parent 3d9435f
commit 99b23f7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/good-toes-beg.md b/.changeset/good-toes-beg.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/devtools': patch
+---
+
+fix(devtools): fix options undefined cause error
diff --git a/packages/chrome-devtools/src/utils/chrome/post-message.ts b/packages/chrome-devtools/src/utils/chrome/post-message.ts
@@ -8,7 +8,7 @@ const getModuleInfo = (): FederationRuntimePlugin => {
     name: 'mf-devtool-getModuleInfo-plugin',
     loadRemoteSnapshot({ options, moduleInfo, remoteSnapshot, ...res }) {
       const globalSnapshot = helpers.global.getGlobalSnapshot();
-      if (options.inBrowser) {
+      if (!options || options.inBrowser) {
         window.postMessage(
           {
             moduleInfo: globalSnapshot,

diff --git a/packages/chrome-devtools/src/utils/chrome/snapshot-plugin.ts b/packages/chrome-devtools/src/utils/chrome/snapshot-plugin.ts
@@ -16,7 +16,7 @@ const chromeDevtoolsPlugin: () => FederationRuntimePlugin = function () {
     beforeLoadRemoteSnapshot({ options }) {
       const { nativeGlobal } = runtimeHelpers.global;
 
-      if (options.inBrowser) {
+      if (!options || options.inBrowser) {
         const realLocalStorage = nativeGlobal.localStorage || localStorage;
         const debugModuleInfoStr = realLocalStorage.getItem(
           MODULE_DEVTOOL_IDENTIFIER,