From 99b23f71313fa51b4846fddf98f2af718d192111 Mon Sep 17 00:00:00 2001 From: nyqykk <65393845+nyqykk@users.noreply.github.com> Date: Sun, 28 Apr 2024 17:45:08 +0800 Subject: [PATCH] fix(devtools): fix options undefined cause error (#2401) --- .changeset/good-toes-beg.md | 5 +++++ packages/chrome-devtools/src/utils/chrome/post-message.ts | 2 +- packages/chrome-devtools/src/utils/chrome/snapshot-plugin.ts | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/good-toes-beg.md diff --git a/.changeset/good-toes-beg.md b/.changeset/good-toes-beg.md new file mode 100644 index 00000000000..b5b423e9c2c --- /dev/null +++ b/.changeset/good-toes-beg.md @@ -0,0 +1,5 @@ +--- +'@module-federation/devtools': patch +--- + +fix(devtools): fix options undefined cause error diff --git a/packages/chrome-devtools/src/utils/chrome/post-message.ts b/packages/chrome-devtools/src/utils/chrome/post-message.ts index 61db13c8f64..18b7a8fce6e 100644 --- a/packages/chrome-devtools/src/utils/chrome/post-message.ts +++ b/packages/chrome-devtools/src/utils/chrome/post-message.ts @@ -8,7 +8,7 @@ const getModuleInfo = (): FederationRuntimePlugin => { name: 'mf-devtool-getModuleInfo-plugin', loadRemoteSnapshot({ options, moduleInfo, remoteSnapshot, ...res }) { const globalSnapshot = helpers.global.getGlobalSnapshot(); - if (options.inBrowser) { + if (!options || options.inBrowser) { window.postMessage( { moduleInfo: globalSnapshot, diff --git a/packages/chrome-devtools/src/utils/chrome/snapshot-plugin.ts b/packages/chrome-devtools/src/utils/chrome/snapshot-plugin.ts index 4e8e706be29..a8dc24ab877 100644 --- a/packages/chrome-devtools/src/utils/chrome/snapshot-plugin.ts +++ b/packages/chrome-devtools/src/utils/chrome/snapshot-plugin.ts @@ -16,7 +16,7 @@ const chromeDevtoolsPlugin: () => FederationRuntimePlugin = function () { beforeLoadRemoteSnapshot({ options }) { const { nativeGlobal } = runtimeHelpers.global; - if (options.inBrowser) { + if (!options || options.inBrowser) { const realLocalStorage = nativeGlobal.localStorage || localStorage; const debugModuleInfoStr = realLocalStorage.getItem( MODULE_DEVTOOL_IDENTIFIER,