3PC RichText TV textareas suddenly broken in 2.5.x

[pixelchutes]

Summary

Since merging #13045, it seems any TV textarea rendered with 3PC (like Ace) are now broken.

The font + sizing is no longer the same, and the cursor positioning becomes invalid (off to the right), with new characters appearing at the wrong place during insertion.

Step to reproduce

1. Ensure running MODX 2.5.x-dev (62fe227 or above)
2. Create TV textarea(s) for a given Template
3. Install Ace Extra, and activate for use w/ TVs
4. Edit Resource tied to above Template
5. Attempt editing Ace TV

Observed behavior

• TVs rendered by Ace now show incorrect font-family.
• Cursor position is also invalid (appearing off to the right)
• Character insertion is incorrect (appearing off to the left)

Before:

#### After:

Expected behavior

• Font should remain as before ('Monaco', 'Menlo', 'Ubuntu Mono', 'Consolas', 'source-code-pro', monospace;).
• Cursor should show up where you would expect.
• New characters should follow the cursor.

Simply removing the recently added CSS resolves both the look and functionality:

/* Offending CSS */
.modx-tv .x-form-textarea {
    font-family: inherit;
}

Environment

MODX 2.5.x-dev

[Mark-H]

Perhaps the CSS definition in Ace could be more specific? Kinda an addon issue, tho it's annoying it's caused by a core change.

[pixelchutes]

Yeah, I debated where I should file this because of that. Unless there's a way to do it in core to adjust the specificity, potentially accounting for scenario like this? (Long shot? 🏀)

[pixelchutes]

MODX Extras aside, I personally preferred the "Courier New", Courier, monospace font of vanilla TV textarea as it was before. To each their own! Likely depends on how you're using it (such as for code, like JS/JSON/CSS, or simply text.) I could see how each could be better in different scenarios.

[pixelchutes]

Something like this appears to fix:

.modx-tv .x-form-textarea:not(.ace_editor) {
    font-family: inherit;
}

UPDATE: Better, more generic:

.modx-tv .x-form-textarea:not(div) {
    font-family: inherit;
}

[Mark-H]

Yuck.. :/

[pixelchutes]

See 🏀 above 😉

[pixelchutes]

@Mark-H OK, how about now? I rebased to be more generic. :not(div) works just the same, but maintains new core functionality from #13045. No more 3PC-specific mention(s). 👍

[Jako]

Merged into 2.5.1