Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on extending-modx/modx-class/reference/modx.getservice #449

Open
jgulledge19 opened this issue Mar 15, 2023 · 1 comment
Open

Issue on extending-modx/modx-class/reference/modx.getservice #449

jgulledge19 opened this issue Mar 15, 2023 · 1 comment

Comments

@jgulledge19
Copy link

Affected page(s)

PHPStorm states that this method call, modx->getService() is depreciated and states it will be removed in 3.1.

What needs to be improved?

Please list it as depreciated and state how to update or the correct use for v3. This looks like a recommendation: modxcms/revolution#15807 (comment)

Relevant context

Would be helpful to note on https://docs.modx.com/3.x/en/getting-started/upgrading-to-3.0 and https://docs.modx.com/3.x/en/getting-started/upgrading-to-3.0/class-names.

@Mark-H Mark-H removed their assignment Mar 16, 2023
@Mark-H
Copy link
Collaborator

Mark-H commented Mar 16, 2023

This will not be removed in 3.1. It was intended to be replaced fully by the new container but is still used too much, including by core itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants