Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use request query parameters for username #55

Open
moeenio opened this issue Jan 25, 2020 · 1 comment · May be fixed by #58
Open

Use request query parameters for username #55

moeenio opened this issue Jan 25, 2020 · 1 comment · May be fixed by #58
Labels
enhancement New feature or request medium priority Important, but not critical

Comments

@moeenio
Copy link
Owner

moeenio commented Jan 25, 2020

Using a URL query parameter such as ?username or shorter ?u would be great to use to get the username instead of the "hash" at the end of the URL, which is normally used for going to a specific section of a page.

Basically, to get a query parameter in JS, we can use (Source) :

var searchParams = new URLSearchParams(location.search);
var username = searchParams.get("parametername")

To not break things, using a hash would transform it into a query parameter.

@moeenio moeenio added the medium priority Important, but not critical label Jan 25, 2020
@moeenio moeenio added the enhancement New feature or request label Jan 25, 2020
@moeenio moeenio added this to the v1.0.0-beta.2 milestone Jan 26, 2020
@moeenio moeenio removed this from the v1.0.0-beta.2 milestone Feb 19, 2020
@moeenio
Copy link
Owner Author

moeenio commented Feb 19, 2020

I think we'll keep this for a later version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium priority Important, but not critical
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant