Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic TTG mapping for "color" works differently than described in the wiki #601

Open
Swamp-Ig opened this issue Jan 19, 2025 · 0 comments

Comments

@Swamp-Ig
Copy link
Contributor

Documentation states:

color The tool will be mapped to one or more gates based on the filament color. In this case HH will try to exactly match the desired color on a gate that matches its material.

However the actual code doesn't check the material type.

I think probably the best bet would be to push color mapping into the closest_color mapping block, but only accept the mapping if the distance <= 0.02 , but IDK maybe just check for material match in the original block, it's a sensible sanity check.

(NB: this line needs to be <= 0.02, if it's exactly 0.02 then neither this nor the above line will match)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant